Skip to content

libember: add missing <stdexcept> includes for runtime_error#128

Merged
KimonHoffmann merged 2 commits intoLawo:masterfrom
t-esserac-t:forLawoPR
Oct 16, 2025
Merged

libember: add missing <stdexcept> includes for runtime_error#128
KimonHoffmann merged 2 commits intoLawo:masterfrom
t-esserac-t:forLawoPR

Conversation

@t-esserac-t
Copy link
Contributor

@t-esserac-t t-esserac-t commented Oct 13, 2025 •
edited
Loading

Summary

compile error example

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\incl 
ude\vector(24): message : 'std' の宣言を確認してください [C:\Users\issan\Playground\emberplus\ember-plus
\build\libember\ember-static.vcxproj]
C:\Users\issan\Playground\emberplus\ember-plus\libember\Headers\ember\ber\traits\../detail/M 
ultiByte.hpp(102,41): error C3861: 'runtime_error': 識別子が見つかりませんでした [C:\Users\issan\Playgroun
d\emberplus\ember-plus\build\libember\ember-static.vcxproj]

Testing

  • cmake --build build --config Release --parallel (MSVC 19.29)

@t-esserac-t
libember: add missing <stdexcept> includes for runtime_error
029c309 
Signed-off-by: Hanae M / tesseract <issankatansochudoku@gmail.com>
KimonHoffmann
KimonHoffmann requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@KimonHoffmann KimonHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

Could you please put the include directives at the top above #include "../../meta/EnableIf.hpp" and #include "CodecTraits.hpp" respectively, while retaining the empty line below #define ...?

Thank's in advance!

@t-esserac-t
style: reorder include directives to match project convention
fadb069 
Signed-off-by: Hanae M / tesseract <issankatansochudoku@gmail.com>
@t-esserac-t t-esserac-t reopened this Oct 15, 2025
@t-esserac-t
Copy link
Contributor Author

t-esserac-t commented Oct 15, 2025

Hello @KimonHoffmann ,
Thank you for your request. I've modified the files!
(I should have checked DecoderFactory.hpp or AsyncBerReader.ipp before committing - thank you for pointing that out.)

Also, my apologies for closing and reopening this pull request unnecessarily during the process. The commit message didn't pass the DCO-check properly, so I had to redo it.

KimonHoffmann
KimonHoffmann approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@KimonHoffmann KimonHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thank you once more for your contribution!
This looks good to me now.

@KimonHoffmann KimonHoffmann merged commit 036bc21 into Lawo:master Oct 16, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KimonHoffmann KimonHoffmann KimonHoffmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-esserac-t @KimonHoffmann